Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
| Files | Infos | Warnings | Errors |
|---|
| 62 | 0 | 0 | 726 |
Files
hoplugins/Commons.java
| Error | Line |
|---|
| Class should define a constructor. |
16
|
hoplugins/commons/ui/BaseTableModel.java
| Error | Line |
|---|
|
| Method 'isCellEditable' is not designed for extension - needs to be abstract, final or empty. |
39
|
|
| Unused parameter 'row'. |
39
|
|
| Unused parameter 'column'. |
39
|
|
| Method 'getColumnClass' is not designed for extension - needs to be abstract, final or empty. |
50
|
|
| '}' should be on the same line. |
53
|
hoplugins/commons/ui/CompositeIcon.java
| Error | Line |
|---|
|
| Expected @param tag for 'icon1'. |
41
|
|
| Expected @param tag for 'icon2'. |
41
|
|
| Expected @param tag for 'icon1'. |
53
|
|
| Expected @param tag for 'icon2'. |
53
|
|
| Expected @param tag for 'position'. |
53
|
|
| Expected @param tag for 'icon1'. |
67
|
|
| Expected @param tag for 'icon2'. |
67
|
|
| Expected @param tag for 'position'. |
67
|
|
| Expected @param tag for 'horizontalOrientation'. |
68
|
|
| Expected @param tag for 'verticalOrientation'. |
68
|
|
| Method 'getIconHeight' is not designed for extension - needs to be abstract, final or empty. |
81
|
|
| Method 'getIconWidth' is not designed for extension - needs to be abstract, final or empty. |
94
|
|
| Method 'paintIcon' is not designed for extension - needs to be abstract, final or empty. |
111
|
|
| Expected @param tag for 'c'. |
111
|
|
| Expected @param tag for 'g'. |
111
|
|
| Expected @param tag for 'x'. |
111
|
|
| Expected @param tag for 'y'. |
111
|
|
| Variable 'width' should be declared final. |
112
|
|
| Variable 'height' should be declared final. |
113
|
|
| '}' should be on the same line. |
122
|
|
| '}' should be on the same line. |
133
|
|
| '}' should be on the same line. |
141
|
|
| '}' should be on the same line. |
152
|
|
| Method 'paintIcon' is not designed for extension - needs to be abstract, final or empty. |
163
|
|
| Missing a Javadoc comment. |
163
|
|
| More than 5 parameters. |
163
|
hoplugins/commons/ui/DebugWindow.java
| Error | Line |
|---|
|
| Debug statement |
6
|
|
| Debug statement |
8
|
|
| Debug statement |
15
|
|
| Class DebugWindow should be declared as final. |
19
|
|
| Debug statement |
19
|
|
| Debug statement |
22
|
|
| Field 'debugWindow' is used in only one method. |
22
|
|
| Debug statement |
29
|
|
| Debug statement |
45
|
|
| Debug statement |
50
|
|
| Debug statement |
51
|
|
| Debug statement |
52
|
|
| Debug statement |
53
|
|
| Debug statement |
57
|
|
| Debug statement |
62
|
|
| Debug statement |
63
|
|
| Debug statement |
64
|
|
| Debug statement |
65
|
|
| Debug statement |
69
|
|
| Debug statement |
71
|
|
| Debug statement |
73
|
|
| Debug statement |
74
|
|
| Debug statement |
75
|
|
| Debug statement |
79
|
hoplugins/commons/ui/DefaultTableSorter.java
| Error | Line |
|---|
|
| Expected @param tag for 'tableModel'. |
32
|
|
| Expected @param tag for 'tableModel'. |
42
|
|
| Expected @param tag for 'tableHeader'. |
42
|
|
| Expected an @return tag. |
55
|
|
| Method 'getCustomComparator' is not designed for extension - needs to be abstract, final or empty. |
55
|
|
| Expected @param tag for 'column'. |
55
|
|
| Unused parameter 'column'. |
55
|
|
| Expected an @return tag. |
64
|
|
| Method 'hasHeaderLine' is not designed for extension - needs to be abstract, final or empty. |
64
|
|
| Expected an @return tag. |
73
|
|
| Method 'minSortableColumn' is not designed for extension - needs to be abstract, final or empty. |
73
|
hoplugins/commons/ui/InfoPanel.java
| Error | Line |
|---|
|
| Variable 'gridBagLayout1' should be declared final. |
32
|
|
| Variable 'labels' should be declared final. |
36
|
hoplugins/commons/ui/NumberTextField.java
| Error | Line |
|---|
|
| Name '_intDigits' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
15
|
|
| Variable '_intDigits' explicitly initialized to '0' (default value for its type). |
15
|
|
| Field '_maxDigits' is used in only one method. |
16
|
|
| Name '_maxDigits' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
16
|
|
| Variable '_maxDigits' explicitly initialized to '0' (default value for its type). |
16
|
|
| Field '_decDigits' is used in only one method. |
17
|
|
| Name '_decDigits' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
17
|
|
| Variable '_decDigits' explicitly initialized to '0' (default value for its type). |
17
|
|
| Method 'getValue' is not designed for extension - needs to be abstract, final or empty. |
38
|
|
| Variable 's' should be declared final. |
39
|
|
| '}' should be on the same line. |
44
|
|
| Catching 'Exception' is not allowed. |
45
|
|
| Must have at least one statement. |
45
|
|
| Name '_getNewString' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
59
|
|
| Variable 'currentText' should be declared final. |
60
|
|
| Variable 'currLen' should be declared final. |
61
|
|
| '}' should be on the same line. |
66
|
|
| '}' should be on the same line. |
69
|
|
| Name '_validateNumberString' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
86
|
|
| Variable 'newLength' should be declared final. |
91
|
|
| '}' should be on the same line. |
111
|
|
| '}' should be on the same line. |
117
|
|
| Field 'decimal' is used in only one method. |
129
|
|
| '}' should be on the same line. |
154
|
hoplugins/commons/ui/PositioningUtilities.java
| Error | Line |
|---|
|
| Class should define a constructor. |
13
|
|
| Utility classes should not have a public or default constructor. |
13
|
|
| Expected @param tag for 'dialog'. |
19
|
|
| Expected @param tag for 'window'. |
28
|
|
| Expected @param tag for 'dialog'. |
39
|
|
| Variable 'dimension' should be declared final. |
41
|
|
| Variable 'container' should be declared final. |
42
|
|
| Variable 'dimension1' should be declared final. |
43
|
|
| Variable 'i' should be declared final. |
44
|
|
| Variable 'j' should be declared final. |
45
|
|
| Variable 'k' should be declared final. |
46
|
|
| Variable 'l' should be declared final. |
47
|
|
| Variable 'dimension2' should be declared final. |
50
|
|
| Expected @param tag for 'window'. |
66
|
|
| Variable 'dimension' should be declared final. |
67
|
|
| Variable 'dimension1' should be declared final. |
68
|
|
| Variable 'i' should be declared final. |
69
|
|
| Variable 'j' should be declared final. |
70
|
|
| Variable 'k' should be declared final. |
71
|
|
| Variable 'l' should be declared final. |
72
|
|
| Expected @param tag for 'window'. |
82
|
hoplugins/commons/ui/VTextIcon.java
| Error | Line |
|---|
|
| Variable access definition in wrong order. |
33
|
|
| Variable access definition in wrong order. |
36
|
|
| Variable access definition in wrong order. |
39
|
|
| Variable access definition in wrong order. |
42
|
|
| Name 'sDrawsInTopRight' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
49
|
|
| Don't use trailing comments. |
50
|
|
| Don't use trailing comments. |
51
|
|
| Don't use trailing comments. |
55
|
|
| Name 'sDrawsInFarTopRight' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
55
|
|
| Name 'kBufferSpace' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
83
|
|
| Variable 'fComponent' must be private and have accessor methods. |
87
|
|
| Variable 'fLabel' must be private and have accessor methods. |
91
|
|
| Don't use trailing comments. |
95
|
|
| Variable 'fCharStrings' must be private and have accessor methods. |
95
|
|
| Don't use trailing comments. |
99
|
|
| Variable 'fCharWidths' must be private and have accessor methods. |
99
|
|
| Don't use trailing comments. |
103
|
|
| Variable 'fPosition' must be private and have accessor methods. |
103
|
|
| Don't use trailing comments. |
107
|
|
| Variable 'fCharHeight' must be private and have accessor methods. |
107
|
|
| Don't use trailing comments. |
111
|
|
| Variable 'fDescent' must be private and have accessor methods. |
111
|
|
| Don't use trailing comments. |
115
|
|
| Variable 'fHeight' must be private and have accessor methods. |
115
|
|
| Variable 'fRotation' must be private and have accessor methods. |
119
|
|
| Don't use trailing comments. |
123
|
|
| Variable 'fWidth' must be private and have accessor methods. |
123
|
|
| Method 'getIconHeight' is not designed for extension - needs to be abstract, final or empty. |
155
|
|
| Method 'getIconWidth' is not designed for extension - needs to be abstract, final or empty. |
164
|
|
| Method 'setLabel' is not designed for extension - needs to be abstract, final or empty. |
174
|
|
| Don't use trailing comments. |
176
|
|
| Method 'paintIcon' is not designed for extension - needs to be abstract, final or empty. |
189
|
|
| Expected @param tag for 'c'. |
189
|
|
| Expected @param tag for 'g'. |
189
|
|
| Expected @param tag for 'x'. |
189
|
|
| Expected @param tag for 'y'. |
189
|
|
| switch without "default" clause. |
203
|
|
| Don't use trailing comments. |
213
|
|
| '}' should be on the same line. |
227
|
|
| '}' should be on the same line. |
234
|
|
| Method 'propertyChange' is not designed for extension - needs to be abstract, final or empty. |
250
|
|
| Expected @param tag for 'e'. |
250
|
|
| Variable 'prop' should be declared final. |
251
|
|
| Expected an @return tag. |
288
|
|
| Expected @param tag for 'label'. |
288
|
|
| Expected @param tag for 'rotateHint'. |
288
|
|
| Don't use trailing comments. |
290
|
|
| Variable 'len' should be declared final. |
292
|
|
| Variable 'data' should be declared final. |
293
|
|
| Don't use trailing comments. |
309
|
|
| Don't use trailing comments. |
310
|
|
| Don't use trailing comments. |
311
|
|
| Variable 'legal' should be declared final. |
321
|
|
| Avoid inline conditionals. |
321
|
|
| Avoid inline conditionals. |
328
|
|
| Method 'calcDimensions' is not designed for extension - needs to be abstract, final or empty. |
334
|
|
| Variable 'fm' should be declared final. |
335
|
|
| Variable 'len' should be declared final. |
341
|
|
| Variable 'data' should be declared final. |
342
|
|
| Don't use trailing comments. |
367
|
|
| '}' should be on the same line. |
369
|
|
| '}' should be on the same line. |
372
|
|
| '}' should be on the same line. |
380
|
|
| Method 'recalcDimensions' is not designed for extension - needs to be abstract, final or empty. |
393
|
|
| Variable 'wOld' should be declared final. |
394
|
|
| Variable 'hOld' should be declared final. |
395
|
hoplugins/commons/ui/info/clearthought/layout/TableLayout.java
| Error | Line |
|---|
|
| Unclosed HTML tag found: <spc> |
116
|
|
| Name 'defaultSize' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
140
|
|
| Variable 'checkForComponentOrientationSupport' must be private and have accessor methods. |
152
|
|
| Variable 'methodGetComponentOrientation' must be private and have accessor methods. |
159
|
|
| Declaring variables, return values or parameters of type 'LinkedList' is not allowed. |
162
|
|
| Variable 'list' must be private and have accessor methods. |
162
|
|
| Variable 'crOffset' must be private and have accessor methods. |
169
|
|
| Variable 'crSize' must be private and have accessor methods. |
172
|
|
| Variable 'crSpec' must be private and have accessor methods. |
175
|
|
| Variable 'dirty' must be private and have accessor methods. |
182
|
|
| Variable 'hGap' must be private and have accessor methods. |
185
|
|
| Variable 'oldHeight' must be private and have accessor methods. |
188
|
|
| Variable 'oldWidth' must be private and have accessor methods. |
191
|
|
| Variable 'vGap' must be private and have accessor methods. |
194
|
|
| '}' should be on the same line. |
222
|
|
| Don't use trailing comments. |
225
|
|
| Don't use trailing comments. |
226
|
|
| Don't use trailing comments. |
227
|
|
| Method 'setColumn' is not designed for extension - needs to be abstract, final or empty. |
260
|
|
| Method 'setColumn' is not designed for extension - needs to be abstract, final or empty. |
280
|
|
| Method 'getColumn' is not designed for extension - needs to be abstract, final or empty. |
291
|
|
| Variable 'column' should be declared final. |
293
|
|
| Method 'getColumn' is not designed for extension - needs to be abstract, final or empty. |
310
|
|
| Method 'setConstraints' is not designed for extension - needs to be abstract, final or empty. |
322
|
|
| Don't use trailing comments. |
327
|
|
| '}' should be on the same line. |
328
|
|
| Don't use trailing comments. |
331
|
|
| Variable 'iterator' should be declared final. |
335
|
|
| Variable 'entry' should be declared final. |
338
|
|
| Method 'getConstraints' is not designed for extension - needs to be abstract, final or empty. |
358
|
|
| Variable 'iterator' should be declared final. |
359
|
|
| Variable 'entry' should be declared final. |
362
|
|
| Method 'setHGap' is not designed for extension - needs to be abstract, final or empty. |
381
|
|
| '}' should be on the same line. |
384
|
|
| Don't use trailing comments. |
387
|
|
| Method 'getHGap' is not designed for extension - needs to be abstract, final or empty. |
396
|
|
| Method 'getInvalidEntry' is not designed for extension - needs to be abstract, final or empty. |
412
|
|
| Declaring variables, return values or parameters of type 'LinkedList' is not allowed. |
413
|
|
| Variable 'listInvalid' should be declared final. |
413
|
|
| Variable 'iterator' should be declared final. |
416
|
|
| Variable 'entry' should be declared final. |
419
|
|
| '}' should be on the same line. |
427
|
|
| Don't use trailing comments. |
429
|
|
| Method 'getLayoutAlignmentX' is not designed for extension - needs to be abstract, final or empty. |
445
|
|
| Unused parameter 'parent'. |
445
|
|
| Method 'getLayoutAlignmentY' is not designed for extension - needs to be abstract, final or empty. |
459
|
|
| Expected @param tag for 'parent'. |
459
|
|
| Unused parameter 'parent'. |
459
|
|
| Method 'getNumColumn' is not designed for extension - needs to be abstract, final or empty. |
468
|
|
| Method 'getNumRow' is not designed for extension - needs to be abstract, final or empty. |
477
|
|
| Unused @throws tag for 'RuntimeException'. |
487
|
|
| Method 'getOverlappingEntry' is not designed for extension - needs to be abstract, final or empty. |
491
|
|
| Declaring variables, return values or parameters of type 'LinkedList' is not allowed. |
492
|
|
| Variable 'listOverlapping' should be declared final. |
492
|
|
| Variable 'numEntry' should be declared final. |
496
|
|
| Variable 'entry' should be declared final. |
504
|
|
| '}' should be on the same line. |
522
|
|
| Don't use trailing comments. |
524
|
|
| Method 'setRow' is not designed for extension - needs to be abstract, final or empty. |
544
|
|
| Method 'setRow' is not designed for extension - needs to be abstract, final or empty. |
564
|
|
| Method 'getRow' is not designed for extension - needs to be abstract, final or empty. |
575
|
|
| Variable 'row' should be declared final. |
577
|
|
| Method 'getRow' is not designed for extension - needs to be abstract, final or empty. |
594
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
603
|
|
| Method 'setVGap' is not designed for extension - needs to be abstract, final or empty. |
605
|
|
| '}' should be on the same line. |
608
|
|
| Don't use trailing comments. |
611
|
|
| Method 'getVGap' is not designed for extension - needs to be abstract, final or empty. |
620
|
|
| Method 'addLayoutComponent' is not designed for extension - needs to be abstract, final or empty. |
630
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
644
|
|
| Method 'addLayoutComponent' is not designed for extension - needs to be abstract, final or empty. |
646
|
|
| Assignment of parameter 'constraint' is not allowed. |
649
|
|
| '}' should be on the same line. |
656
|
|
| '}' should be on the same line. |
663
|
|
| Don't use trailing comments. |
666
|
|
| '}' should be on the same line. |
667
|
|
| Don't use trailing comments. |
670
|
|
| Method 'deleteColumn' is not designed for extension - needs to be abstract, final or empty. |
684
|
|
| Method 'deleteRow' is not designed for extension - needs to be abstract, final or empty. |
698
|
|
| Method 'insertColumn' is not designed for extension - needs to be abstract, final or empty. |
717
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
728
|
|
| Method 'insertCr' is not designed for extension - needs to be abstract, final or empty. |
730
|
|
| Don't use trailing comments. |
734
|
|
| Don't use trailing comments. |
735
|
|
| Assignment of parameter 'size' is not allowed. |
741
|
|
| Variable 'iterator' should be declared final. |
755
|
|
| Variable 'entry' should be declared final. |
759
|
|
| Method 'insertRow' is not designed for extension - needs to be abstract, final or empty. |
789
|
|
| Method 'invalidateLayout' is not designed for extension - needs to be abstract, final or empty. |
799
|
|
| Unused parameter 'target'. |
799
|
|
| Method 'layoutContainer' is not designed for extension - needs to be abstract, final or empty. |
817
|
|
| Variable 'd' should be declared final. |
819
|
|
| Variable 'component' should be declared final. |
826
|
|
| Variable 'iterator' should be declared final. |
832
|
|
| '}' should be on the same line. |
840
|
|
| Variable 'preferredSize' should be declared final. |
865
|
|
| Variable 'w' should be declared final. |
875
|
|
| Variable 'y' should be declared final. |
879
|
|
| Variable 'h' should be declared final. |
880
|
|
| Variable 'co' should be declared final. |
883
|
|
| '}' should be on the same line. |
891
|
|
| Catching 'Exception' is not allowed. |
892
|
|
| Method 'maximumLayoutSize' is not designed for extension - needs to be abstract, final or empty. |
911
|
|
| Unused parameter 'target'. |
911
|
|
| Method 'minimumLayoutSize' is not designed for extension - needs to be abstract, final or empty. |
929
|
|
| Method 'preferredLayoutSize' is not designed for extension - needs to be abstract, final or empty. |
948
|
|
| Method 'removeLayoutComponent' is not designed for extension - needs to be abstract, final or empty. |
957
|
|
| Variable 'iterator' should be declared final. |
959
|
|
| Variable 'entry' should be declared final. |
962
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
983
|
|
| Don't use trailing comments. |
986
|
|
| Don't use trailing comments. |
990
|
|
| Unnecessary parentheses around assignment right-hand side. |
990
|
|
| Don't use trailing comments. |
993
|
|
| Unnecessary parentheses around assignment right-hand side. |
993
|
|
| '}' should be on the same line. |
994
|
|
| Don't use trailing comments. |
996
|
|
| Don't use trailing comments. |
1001
|
|
| Unnecessary parentheses around assignment right-hand side. |
1001
|
|
| Don't use trailing comments. |
1004
|
|
| Unnecessary parentheses around assignment right-hand side. |
1004
|
|
| '}' should be on the same line. |
1005
|
|
| Don't use trailing comments. |
1007
|
|
| Method 'getComponentOrientation' is not designed for extension - needs to be abstract, final or empty. |
1021
|
|
| Don't use trailing comments. |
1030
|
|
| Don't use trailing comments. |
1031
|
|
| '(' should be on the previous line. |
1031
|
|
| '}' should be on the same line. |
1040
|
|
| Catching 'Exception' is not allowed. |
1041
|
|
| Must have at least one statement. |
1041
|
|
| Method 'setCr' is not designed for extension - needs to be abstract, final or empty. |
1053
|
|
| Method 'setCr' is not designed for extension - needs to be abstract, final or empty. |
1078
|
|
| Assignment of parameter 'size' is not allowed. |
1082
|
|
| Method 'assignAbsoluteSize' is not designed for extension - needs to be abstract, final or empty. |
1100
|
|
| Variable 'numCr' should be declared final. |
1101
|
|
| Assignment of parameter 'availableSize' is not allowed. |
1106
|
|
| Method 'assignFillSize' is not designed for extension - needs to be abstract, final or empty. |
1119
|
|
| Variable 'numCr' should be declared final. |
1127
|
|
| Method 'assignPrefMinSize' is not designed for extension - needs to be abstract, final or empty. |
1173
|
|
| Method length is 61 lines (max allowed is 50). |
1173
|
|
| Variable 'numCr' should be declared final. |
1175
|
|
| Variable 'iterator' should be declared final. |
1186
|
|
| Variable 'entry' should be declared final. |
1190
|
|
| Variable 'p' should be declared final. |
1201
|
|
| Avoid inline conditionals. |
1202
|
|
| Avoid inline conditionals. |
1205
|
|
| Avoid inline conditionals. |
1205
|
|
| '}' should be on the same line. |
1219
|
|
| '}' should be on the same line. |
1224
|
|
| '}' should be on the same line. |
1233
|
|
| '}' should be on the same line. |
1244
|
|
| '}' should be on the same line. |
1250
|
|
| Assignment of parameter 'availableSize' is not allowed. |
1275
|
|
| Method 'assignRelativeSize' is not designed for extension - needs to be abstract, final or empty. |
1290
|
|
| Variable 'relativeSize' should be declared final. |
1291
|
|
| Avoid inline conditionals. |
1291
|
|
| Variable 'numCr' should be declared final. |
1292
|
|
| Assignment of parameter 'availableSize' is not allowed. |
1299
|
|
| Method 'calculateLayoutSize' is not designed for extension - needs to be abstract, final or empty. |
1315
|
|
| Variable 'entryList' should be declared final. |
1318
|
|
| Variable 'numEntry' should be declared final. |
1319
|
|
| Variable 'prefMinSize' should be declared final. |
1320
|
|
| Avoid inline conditionals. |
1324
|
|
| Variable 'inset' should be declared final. |
1336
|
|
| Unnecessary parentheses around assignment right-hand side. |
1338
|
|
| Unnecessary parentheses around assignment right-hand side. |
1339
|
|
| Method 'calculateLayoutSize' is not designed for extension - needs to be abstract, final or empty. |
1358
|
|
| Method length is 87 lines (max allowed is 50). |
1358
|
|
| Unused parameter 'container'. |
1358
|
|
| Don't use trailing comments. |
1360
|
|
| Don't use trailing comments. |
1361
|
|
| Don't use trailing comments. |
1362
|
|
| Don't use trailing comments. |
1363
|
|
| Variable 'numCr' should be declared final. |
1366
|
|
| '}' should be on the same line. |
1376
|
|
| Variable 'crPrefMin' should be declared final. |
1403
|
|
| Variable 'numColumn' should be declared final. |
1413
|
|
| Variable 'numRow' should be declared final. |
1414
|
|
| Variable 'numEntry' should be declared final. |
1415
|
|
| Variable 'entry' should be declared final. |
1419
|
|
| Avoid inline conditionals. |
1434
|
|
| '}' should be on the same line. |
1439
|
|
| '}' should be on the same line. |
1456
|
|
| '}' should be on the same line. |
1468
|
|
| '}' should be on the same line. |
1488
|
|
| Unnecessary parentheses around assignment right-hand side. |
1500
|
|
| Avoid inline conditionals. |
1500
|
|
| Method 'calculateOffset' is not designed for extension - needs to be abstract, final or empty. |
1512
|
|
| Variable 'numCr' should be declared final. |
1513
|
|
| Avoid inline conditionals. |
1516
|
|
| Method 'calculateSize' is not designed for extension - needs to be abstract, final or empty. |
1535
|
|
| Variable 'inset' should be declared final. |
1537
|
|
| Variable 'd' should be declared final. |
1540
|
|
| Unnecessary parentheses around assignment right-hand side. |
1546
|
|
| Unnecessary parentheses around assignment right-hand side. |
1550
|
|
| Method 'calculateSizeAndOffset' is not designed for extension - needs to be abstract, final or empty. |
1596
|
|
| 'crOffset' hides a field. |
1599
|
|
| Variable 'crOffset' should be declared final. |
1599
|
|
| Avoid inline conditionals. |
1599
|
|
| Avoid inline conditionals. |
1600
|
|
| Avoid inline conditionals. |
1604
|
|
| '}' should be on the same line. |
1612
|
|
| Don't use trailing comments. |
1632
|
|
| Avoid inline conditionals. |
1633
|
|
| Don't use trailing comments. |
1637
|
|
| Avoid inline conditionals. |
1638
|
|
| Don't use trailing comments. |
1643
|
|
| Avoid inline conditionals. |
1644
|
|
| Don't use trailing comments. |
1649
|
|
| Avoid inline conditionals. |
1650
|
|
| Don't use trailing comments. |
1654
|
|
| Unnecessary parentheses around assignment right-hand side. |
1660
|
|
| Unnecessary parentheses around assignment right-hand side. |
1661
|
|
| '}' should be on the same line. |
1662
|
|
| Unnecessary parentheses around assignment right-hand side. |
1664
|
|
| Unnecessary parentheses around assignment right-hand side. |
1665
|
|
| Variable 'value' should be declared final. |
1669
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
1680
|
|
| Method 'deleteCr' is not designed for extension - needs to be abstract, final or empty. |
1682
|
|
| Don't use trailing comments. |
1686
|
|
| Don't use trailing comments. |
1687
|
|
| Variable 'iterator' should be declared final. |
1700
|
|
| Variable 'entry' should be declared final. |
1704
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
1729
|
|
| Method 'init' is not designed for extension - needs to be abstract, final or empty. |
1731
|
|
| Don't use trailing comments. |
1734
|
|
| Don't use trailing comments. |
1738
|
|
| Missing a Javadoc comment. |
1777
|
|
| Variable 'component' must be private and have accessor methods. |
1779
|
|
| Variable 'alignment' must be private and have accessor methods. |
1782
|
|
| Variable 'cr1' must be private and have accessor methods. |
1785
|
|
| Variable 'cr2' must be private and have accessor methods. |
1788
|
|
| 'cr1' hides a field. |
1797
|
|
| 'cr2' hides a field. |
1798
|
|
| 'alignment' hides a field. |
1799
|
|
| Method 'copy' is not designed for extension - needs to be abstract, final or empty. |
1814
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
1823
|
|
| Variable 'c' should be declared final. |
1824
|
|
| Don't use trailing comments. |
1827
|
hoplugins/commons/ui/info/clearthought/layout/TableLayoutConstants.java
| Error | Line |
|---|
|
| interfaces should describe a type and hence have methods. |
44
|
|
| Redundant 'public' modifier. |
46
|
|
| Redundant 'public' modifier. |
49
|
|
| Redundant 'public' modifier. |
52
|
|
| Redundant 'public' modifier. |
55
|
|
| Redundant 'public' modifier. |
58
|
|
| Redundant 'public' modifier. |
61
|
|
| Redundant 'public' modifier. |
69
|
|
| Redundant 'public' modifier. |
77
|
|
| Redundant 'public' modifier. |
80
|
|
| Redundant 'public' modifier. |
86
|
|
| Redundant 'public' modifier. |
92
|
hoplugins/commons/ui/info/clearthought/layout/TableLayoutConstraints.java
| Error | Line |
|---|
|
| Variable 'col1' must be private and have accessor methods. |
48
|
|
| Variable 'col2' must be private and have accessor methods. |
51
|
|
| Variable 'hAlign' must be private and have accessor methods. |
54
|
|
| Variable 'row1' must be private and have accessor methods. |
57
|
|
| Variable 'row2' must be private and have accessor methods. |
60
|
|
| Variable 'vAlign' must be private and have accessor methods. |
63
|
|
| Inner assignments should be avoided. |
70
|
|
| Inner assignments should be avoided. |
70
|
|
| Inner assignments should be avoided. |
70
|
|
| Inner assignments should be avoided. |
71
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
82
|
|
| Don't use trailing comments. |
96
|
|
| Variable 'st' should be declared final. |
96
|
|
| Variable 'numToken' should be declared final. |
97
|
|
| '}' should be on the same line. |
129
|
|
| Don't use trailing comments. |
137
|
|
| '}' should be on the same line. |
139
|
|
| Don't use trailing comments. |
140
|
|
| Don't use trailing comments. |
141
|
|
| '}' should be on the same line. |
143
|
|
| Don't use trailing comments. |
144
|
|
| Don't use trailing comments. |
145
|
|
| '}' should be on the same line. |
147
|
|
| Don't use trailing comments. |
148
|
|
| Don't use trailing comments. |
149
|
|
| '}' should be on the same line. |
151
|
|
| Don't use trailing comments. |
152
|
|
| Don't use trailing comments. |
153
|
|
| '}' should be on the same line. |
155
|
|
| Don't use trailing comments. |
156
|
|
| Don't use trailing comments. |
157
|
|
| '}' should be on the same line. |
159
|
|
| Don't use trailing comments. |
166
|
|
| '}' should be on the same line. |
168
|
|
| Don't use trailing comments. |
169
|
|
| Don't use trailing comments. |
170
|
|
| '}' should be on the same line. |
172
|
|
| Don't use trailing comments. |
173
|
|
| Don't use trailing comments. |
174
|
|
| '}' should be on the same line. |
176
|
|
| Don't use trailing comments. |
177
|
|
| Don't use trailing comments. |
178
|
|
| '}' should be on the same line. |
180
|
|
| '}' should be on the same line. |
184
|
|
| Must have at least one statement. |
185
|
|
| '}' should be on the same line. |
186
|
|
| Catching 'RuntimeException' is not allowed. |
187
|
|
| Don't use trailing comments. |
189
|
|
| Don't use trailing comments. |
190
|
|
| Don't use trailing comments. |
191
|
|
| Don't use trailing comments. |
192
|
|
| Don't use trailing comments. |
193
|
|
| More than 5 parameters. |
217
|
|
| '}' should be on the same line. |
227
|
|
| '}' should be on the same line. |
234
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
246
|
|
| Variable 'buffer' should be declared final. |
247
|
|
| Don't use trailing comments. |
250
|
|
| Don't use trailing comments. |
252
|
|
| Don't use trailing comments. |
255
|
|
| Don't use trailing comments. |
257
|
|
| Don't use trailing comments. |
260
|
|
| Don't use trailing comments. |
263
|
|
| Don't use trailing comments. |
266
|
hoplugins/commons/ui/renderer/HtmlCellRenderer.java
| Error | Line |
|---|
|
| Method 'getTableCellRendererComponent' is not designed for extension - needs to be abstract, final or empty. |
38
|
|
| Missing a Javadoc comment. |
38
|
|
| More than 5 parameters. |
38
|
|
| Unused parameter 'hasFocus'. |
39
|
|
| Unused parameter 'row'. |
39
|
|
| Unused parameter 'column'. |
39
|
hoplugins/commons/ui/renderer/TextAreaCellRenderer.java
| Error | Line |
|---|
|
| Method 'getTableCellRendererComponent' is not designed for extension - needs to be abstract, final or empty. |
39
|
|
| Missing a Javadoc comment. |
39
|
|
| More than 5 parameters. |
39
|
|
| Unused parameter 'hasFocus'. |
40
|
|
| Unused parameter 'column'. |
40
|
|
| Name 'height_wanted' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
44
|
|
| Variable 'height_wanted' should be declared final. |
44
|
hoplugins/commons/ui/sorter/AbstractTableSorter.java
| Error | Line |
|---|
|
| Name 'EMPTY_DIRECTIVE' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
63
|
|
| Variable access definition in wrong order. |
67
|
|
| Variable access definition in wrong order. |
75
|
|
| Variable 'tableModel' must be private and have accessor methods. |
83
|
|
| Expected @param tag for 'tableModel'. |
105
|
|
| Expected @param tag for 'tableModel'. |
116
|
|
| Expected @param tag for 'tableHeader'. |
116
|
|
| Expected an @return tag. |
130
|
|
| Method 'isCellEditable' is not designed for extension - needs to be abstract, final or empty. |
130
|
|
| Expected @param tag for 'row'. |
130
|
|
| Expected @param tag for 'column'. |
130
|
|
| Expected an @return tag. |
141
|
|
| Method 'getColumnClass' is not designed for extension - needs to be abstract, final or empty. |
141
|
|
| Expected @param tag for 'column'. |
141
|
|
| Method 'setColumnComparator' is not designed for extension - needs to be abstract, final or empty. |
151
|
|
| Expected @param tag for 'type'. |
151
|
|
| Expected @param tag for 'comparator'. |
151
|
|
| '}' should be on the same line. |
154
|
|
| Expected an @return tag. |
165
|
|
| Method 'getColumnCount' is not designed for extension - needs to be abstract, final or empty. |
165
|
|
| Avoid inline conditionals. |
166
|
|
| Expected an @return tag. |
176
|
|
| Method 'getColumnName' is not designed for extension - needs to be abstract, final or empty. |
176
|
|
| Expected @param tag for 'column'. |
176
|
|
| Expected an @return tag. |
187
|
|
| Expected @param tag for 'column'. |
187
|
|
| Method 'getRowCount' is not designed for extension - needs to be abstract, final or empty. |
190
|
|
| Missing a Javadoc comment. |
190
|
|
| Avoid inline conditionals. |
191
|
|
| Expected an @return tag. |
199
|
|
| Method 'isSorting' is not designed for extension - needs to be abstract, final or empty. |
199
|
|
| Expected an @return tag. |
208
|
|
| Method 'getSortingColumns' is not designed for extension - needs to be abstract, final or empty. |
208
|
|
| Method 'setSortingStatus' is not designed for extension - needs to be abstract, final or empty. |
218
|
|
| Expected @param tag for 'column'. |
218
|
|
| Expected @param tag for 'status'. |
218
|
|
| Variable 'directive' should be declared final. |
219
|
|
| Expected an @return tag. |
239
|
|
| Method 'getSortingStatus' is not designed for extension - needs to be abstract, final or empty. |
239
|
|
| Expected @param tag for 'column'. |
239
|
|
| Method 'setTableHeader' is not designed for extension - needs to be abstract, final or empty. |
248
|
|
| Expected @param tag for 'tableHeader'. |
248
|
|
| Variable 'defaultRenderer' should be declared final. |
252
|
|
| Expected an @return tag. |
275
|
|
| Method 'getTableHeader' is not designed for extension - needs to be abstract, final or empty. |
275
|
|
| Method 'setTableModel' is not designed for extension - needs to be abstract, final or empty. |
284
|
|
| Expected @param tag for 'tableModel'. |
284
|
|
| Expected an @return tag. |
304
|
|
| Method 'getTableModel' is not designed for extension - needs to be abstract, final or empty. |
304
|
|
| Method 'setValueAt' is not designed for extension - needs to be abstract, final or empty. |
315
|
|
| Expected @param tag for 'aValue'. |
315
|
|
| Expected @param tag for 'row'. |
315
|
|
| Expected @param tag for 'column'. |
315
|
|
| Expected an @return tag. |
327
|
|
| Method 'getValueAt' is not designed for extension - needs to be abstract, final or empty. |
327
|
|
| Expected @param tag for 'row'. |
327
|
|
| Expected @param tag for 'column'. |
327
|
|
| Expected an @return tag. |
336
|
|
| Expected an @return tag. |
343
|
|
| Expected an @return tag. |
352
|
|
| Method 'modelIndex' is not designed for extension - needs to be abstract, final or empty. |
352
|
|
| Expected @param tag for 'viewIndex'. |
352
|
|
| Expected an @return tag. |
363
|
|
| Method 'getComparator' is not designed for extension - needs to be abstract, final or empty. |
363
|
|
| Expected @param tag for 'column'. |
363
|
|
| Variable 'columnType' should be declared final. |
370
|
|
| Expected an @return tag. |
393
|
|
| Method 'getHeaderRendererIcon' is not designed for extension - needs to be abstract, final or empty. |
393
|
|
| Expected @param tag for 'column'. |
393
|
|
| Expected @param tag for 'size'. |
393
|
|
| Variable 'directive' should be declared final. |
394
|
|
| Javadoc has empty description section. |
404
|
|
| Method 'cancelSorting' is not designed for extension - needs to be abstract, final or empty. |
407
|
|
| Expected an @return tag. |
417
|
|
| Method 'getModelToView' is not designed for extension - needs to be abstract, final or empty. |
417
|
|
| Variable 'n' should be declared final. |
419
|
|
| Javadoc has empty description section. |
431
|
|
| Method 'clearSortingState' is not designed for extension - needs to be abstract, final or empty. |
434
|
|
| Expected an @return tag. |
446
|
|
| Expected @param tag for 'column'. |
446
|
|
| Variable 'directive' should be declared final. |
448
|
|
| Expected an @return tag. |
463
|
|
| Variable 'tableModelRowCount' should be declared final. |
465
|
|
| Javadoc has empty description section. |
481
|
hoplugins/commons/ui/sorter/Arrow.java
| Error | Line |
|---|
|
| Expected @param tag for 'descending'. |
33
|
|
| Expected @param tag for 'size'. |
33
|
|
| Expected @param tag for 'priority'. |
33
|
|
| Expected an @return tag. |
44
|
|
| Expected an @return tag. |
53
|
|
| Expected @param tag for 'c'. |
65
|
|
| Expected @param tag for 'g'. |
65
|
|
| Expected @param tag for 'x'. |
65
|
|
| Expected @param tag for 'y'. |
65
|
|
| Variable 'color' should be declared final. |
66
|
|
| Avoid inline conditionals. |
66
|
|
| Variable 'dx' should be declared final. |
70
|
|
| Variable 'dy' should be declared final. |
71
|
|
| Avoid inline conditionals. |
71
|
|
| Assignment of parameter 'y' is not allowed. |
74
|
|
| Avoid inline conditionals. |
74
|
|
| Variable 'shift' should be declared final. |
76
|
|
| Avoid inline conditionals. |
76
|
|
| '}' should be on the same line. |
93
|
hoplugins/commons/ui/sorter/Directive.java
| Error | Line |
|---|
|
| Expected @param tag for 'column'. |
26
|
|
| Expected @param tag for 'direction'. |
26
|
|
| Expected an @return tag. |
36
|
|
| Expected an @return tag. |
45
|
hoplugins/commons/ui/sorter/MouseHandler.java
| Error | Line |
|---|
|
| Declaring variables, return values or parameters of type 'AbstractTableSorter' is not allowed. |
23
|
|
| Expected @param tag for 'sorter'. |
30
|
|
| Expected @param tag for 'e'. |
41
|
|
| Variable 'h' should be declared final. |
42
|
|
| Variable 'columnModel' should be declared final. |
43
|
|
| Variable 'viewColumn' should be declared final. |
44
|
|
| Avoid inline conditionals. |
61
|
|
| Don't use trailing comments. |
62
|
hoplugins/commons/ui/sorter/Row.java
| Error | Line |
|---|
|
| Missing a Javadoc comment. |
13
|
|
| Declaring variables, return values or parameters of type 'AbstractTableSorter' is not allowed. |
15
|
|
| Expected @param tag for 'sorter'. |
24
|
|
| Expected @param tag for 'index'. |
24
|
|
| Expected an @return tag. |
34
|
|
| Expected an @return tag. |
45
|
|
| Expected @param tag for 'o'. |
45
|
|
| Variable 'row1' should be declared final. |
46
|
|
| Variable 'row2' should be declared final. |
47
|
|
| Variable 'it' should be declared final. |
59
|
|
| Variable 'directive' should be declared final. |
61
|
|
| Variable 'column' should be declared final. |
62
|
|
| Variable 'o1' should be declared final. |
63
|
|
| Variable 'o2' should be declared final. |
64
|
|
| '}' should be on the same line. |
71
|
|
| '}' should be on the same line. |
74
|
|
| '}' should be on the same line. |
77
|
|
| Avoid inline conditionals. |
84
|
hoplugins/commons/ui/sorter/SortableHeaderRenderer.java
| Error | Line |
|---|
|
| Declaring variables, return values or parameters of type 'AbstractTableSorter' is not allowed. |
23
|
|
| Expected @param tag for 'sorter'. |
32
|
|
| Expected @param tag for 'tableCellRenderer'. |
33
|
|
| Expected an @return tag. |
43
|
|
| Expected an @return tag. |
59
|
|
| More than 5 parameters. |
59
|
|
| Expected @param tag for 'table'. |
59
|
|
| Expected @param tag for 'value'. |
59
|
|
| Expected @param tag for 'isSelected'. |
60
|
|
| Expected @param tag for 'hasFocus'. |
60
|
|
| Expected @param tag for 'row'. |
60
|
|
| Expected @param tag for 'column'. |
60
|
|
| Variable 'c' should be declared final. |
61
|
|
| Variable 'l' should be declared final. |
65
|
|
| Variable 'modelColumn' should be declared final. |
69
|
hoplugins/commons/ui/sorter/TableModelHandler.java
| Error | Line |
|---|
|
| Declaring variables, return values or parameters of type 'AbstractTableSorter' is not allowed. |
20
|
|
| Expected @param tag for 'sorter'. |
27
|
|
| Expected @param tag for 'e'. |
36
|
|
| Variable 'column' should be declared final. |
73
|
|
| Variable 'viewIndex' should be declared final. |
79
|
hoplugins/commons/utils/Debug.java
| Error | Line |
|---|
|
| Debug statement |
16
|
|
| Utility classes should not have a public or default constructor. |
16
|
|
| Field 'logFile' is used in only one method. |
20
|
|
| Name 'logFile' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
20
|
|
| Field 'separator' is used in only one method. |
23
|
|
| Name 'separator' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
23
|
|
| Debug statement |
28
|
|
| Debug statement |
30
|
|
| Variable 'log' should be declared final. |
42
|
|
| Catching 'Exception' is not allowed. |
45
|
|
| Must have at least one statement. |
45
|
|
| Variable 'log' should be declared final. |
56
|
|
| Catching 'Exception' is not allowed. |
59
|
|
| Must have at least one statement. |
59
|
|
| Variable 'file' should be declared final. |
73
|
|
| Variable 'date' should be declared final. |
77
|
|
| Catching 'Exception' is not allowed. |
81
|
|
| Must have at least one statement. |
81
|
hoplugins/commons/utils/HTCalendar.java
| Error | Line |
|---|
|
| Field 'MIN_ELAPSED_WEEKS' is used in only one method. |
50
|
|
| Field 'SE_CORRECTION' is used in only one method. |
57
|
|
| '}' should be on the same line. |
84
|
|
| '}' should be on the same line. |
91
|
|
| '}' should be on the same line. |
106
|
|
| '}' should be on the same line. |
113
|
|
| Unnecessary parentheses around assignment right-hand side. |
195
|
|
| Unnecessary parentheses around assignment right-hand side. |
208
|
hoplugins/commons/utils/PluginProperty.java
| Error | Line |
|---|
|
| Don't use trailing comments. |
29
|
|
| Field 'languageID' is used in only one method. |
29
|
|
| Variable 'code' should be declared final. |
53
|
|
| Variable 'parts' should be declared final. |
59
|
|
| Variable 'bundle' should be declared final. |
123
|
|
| Variable 'e' should be declared final. |
127
|
|
| Variable 's' should be declared final. |
128
|
|
| Catching 'Exception' is not allowed. |
134
|
|
| Don't use trailing comments. |
139
|
|
| Don't use trailing comments. |
146
|
|
| Must have at least one statement. |
149
|
|
| Don't use trailing comments. |
179
|
|
| Variable 'file' should be declared final. |
179
|
|
| Must have at least one statement. |
183
|
|
| Don't use trailing comments. |
195
|
|
| Don't use trailing comments. |
202
|
hoplugins/commons/utils/RatingUtil.java
| Error | Line |
|---|
|
| '}' should be on the same line. |
46
|
|
| '}' should be on the same line. |
49
|
|
| '}' should be on the same line. |
52
|
|
| '}' should be on the same line. |
68
|
|
| '}' should be on the same line. |
114
|
|
| '}' should be on the same line. |
118
|
|
| '}' should be on the same line. |
122
|
|
| '}' should be on the same line. |
126
|
hoplugins/commons/utils/SeriesUtil.java
| Error | Line |
|---|
|
| Return count is 14 (max allowed is 5). |
30
|
|
| Variable 'st' should be declared final. |
31
|
|
| Variable 'level' should be declared final. |
32
|
hoplugins/commons/vo/MatchRating.java
| Error | Line |
|---|
|
| Class should define a constructor. |
12
|
|
| Name 'MIDFIELD_SHIFT' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
117
|
|
| Name 'COUNTERATTACK_WEIGHT' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
118
|
|
| Name 'DEFENSE_WEIGHT' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
119
|
|
| Name 'ATTACK_WEIGHT' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
120
|
|
| Name 'CENTRAL_WEIGHT' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
121
|
|
| Name 'WINGER_WEIGTH' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
122
|
|
| Name 'MIDFIELD' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
186
|
|
| Name 'ATTACK' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
187
|
|
| Name 'DEFENSE' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
188
|
|
| Name 'SIDE' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
189
|
|
| Name 'CENTER' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
190
|
